Skip to content

Implement Variant::get_type_by_name()#1975

Merged
dsnopek merged 1 commit intogodotengine:masterfrom
dsnopek:variant-get-type-by-name
May 4, 2026
Merged

Implement Variant::get_type_by_name()#1975
dsnopek merged 1 commit intogodotengine:masterfrom
dsnopek:variant-get-type-by-name

Conversation

@dsnopek
Copy link
Copy Markdown
Collaborator

@dsnopek dsnopek commented Apr 21, 2026

This implements support for godotengine/godot#117160

cc @Naros

Marked as a DRAFT because it depends on #1972

@dsnopek dsnopek added this to the 10.x milestone Apr 21, 2026
@dsnopek dsnopek requested a review from a team as a code owner April 21, 2026 22:15
@dsnopek dsnopek added the enhancement This is an enhancement on the current functionality label Apr 21, 2026
@dsnopek dsnopek marked this pull request as draft April 21, 2026 22:15
@dsnopek dsnopek force-pushed the variant-get-type-by-name branch from a919a35 to 2360bbd Compare May 4, 2026 13:45
@dsnopek dsnopek changed the title [DRAFT] Implement Variant::get_type_by_name() Implement Variant::get_type_by_name() May 4, 2026
@dsnopek dsnopek marked this pull request as ready for review May 4, 2026 13:46
Copy link
Copy Markdown
Member

@Ivorforce Ivorforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#ifdef version makes sense to me.
Only pre-4.7 workaround that would also make sense to me would be re-implementing the function as a fallback, which would also be correct as types are well-known.

@dsnopek
Copy link
Copy Markdown
Collaborator Author

dsnopek commented May 4, 2026

Let's merge this one for now, and we can keep discussing a possible fallback in a follow-up (either as VARIANT_MAX or a fixed mapping)

@dsnopek dsnopek merged commit bc1fcd5 into godotengine:master May 4, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This is an enhancement on the current functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants